-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[llm][WIP] Support TensorRT-LLM in ray data llm #61409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
owenowenisme
wants to merge
1
commit into
ray-project:master
Choose a base branch
from
owenowenisme:data-llm/add-trtllm-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+643
−0
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
238 changes: 238 additions & 0 deletions
238
python/ray/llm/_internal/batch/processor/trtllm_engine_proc.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,238 @@ | ||
| """The SGLang engine processor.""" | ||
|
|
||
| import logging | ||
| from typing import Any, Dict, Optional | ||
|
|
||
| import transformers | ||
| from pydantic import Field, root_validator | ||
|
|
||
| import ray | ||
| from ray.data.block import UserDefinedFunction | ||
| from ray.llm._internal.batch.constants import SGLangTaskType, TypeSGLangTaskType | ||
| from ray.llm._internal.batch.observability.usage_telemetry.usage import ( | ||
| BatchModelTelemetry, | ||
| TelemetryAgent, | ||
| get_or_create_telemetry_agent, | ||
| ) | ||
| from ray.llm._internal.batch.processor.base import ( | ||
| DEFAULT_MAX_TASKS_IN_FLIGHT, | ||
| OfflineProcessorConfig, | ||
| Processor, | ||
| ProcessorBuilder, | ||
| ) | ||
| from ray.llm._internal.batch.processor.utils import ( | ||
| build_cpu_stage_map_kwargs, | ||
| get_value_or_fallback, | ||
| ) | ||
| from ray.llm._internal.batch.stages import ( | ||
| ChatTemplateStage, | ||
| DetokenizeStage, | ||
| SGLangEngineStage, | ||
| TokenizeStage, | ||
| ) | ||
| from ray.llm._internal.batch.stages.configs import ( | ||
| ChatTemplateStageConfig, | ||
| DetokenizeStageConfig, | ||
| TokenizerStageConfig, | ||
| resolve_stage_config, | ||
| ) | ||
| from ray.llm._internal.common.observability.telemetry_utils import DEFAULT_GPU_TYPE | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| DEFAULT_MODEL_ARCHITECTURE = "UNKNOWN_MODEL_ARCHITECTURE" | ||
|
|
||
|
|
||
| class SGLangEngineProcessorConfig(OfflineProcessorConfig): | ||
| """The configuration for the SGLang engine processor.""" | ||
|
|
||
| # SGLang stage configurations. | ||
| engine_kwargs: Dict[str, Any] = Field( | ||
| default_factory=dict, | ||
| description="The kwargs to pass to the SGLang engine. See " | ||
| "https://docs.sglang.ai/backend/server_arguments.html " | ||
| "for more details.", | ||
| ) | ||
| task_type: TypeSGLangTaskType = Field( | ||
| default=SGLangTaskType.GENERATE, | ||
| description="The task type to use. If not specified, will use " | ||
| "'generate' by default.", | ||
| ) | ||
|
|
||
| @root_validator(pre=True) | ||
| def validate_task_type(cls, values): | ||
| task_type = values.get("task_type", SGLangTaskType.GENERATE) | ||
| if task_type not in SGLangTaskType.values(): | ||
| raise ValueError(f"Invalid task type: {task_type}") | ||
|
|
||
| engine_kwargs = values.get("engine_kwargs", {}) | ||
| engine_kwargs_task = engine_kwargs.get("task", "") | ||
| if engine_kwargs_task != task_type: | ||
| logger.warning( | ||
| "The task set in engine kwargs (%s) is different from the " | ||
| "stage (%s). Overriding the task in engine kwargs to %s.", | ||
| engine_kwargs_task, | ||
| task_type, | ||
| task_type, | ||
| ) | ||
| engine_kwargs["task"] = task_type | ||
| values["engine_kwargs"] = engine_kwargs | ||
| return values | ||
|
|
||
|
|
||
| def build_sglang_engine_processor( | ||
| config: SGLangEngineProcessorConfig, | ||
| chat_template_kwargs: Optional[Dict[str, Any]] = None, | ||
| preprocess: Optional[UserDefinedFunction] = None, | ||
| postprocess: Optional[UserDefinedFunction] = None, | ||
| preprocess_map_kwargs: Optional[Dict[str, Any]] = None, | ||
| postprocess_map_kwargs: Optional[Dict[str, Any]] = None, | ||
| telemetry_agent: Optional[TelemetryAgent] = None, | ||
| ) -> Processor: | ||
| """Construct a Processor and configure stages. | ||
|
|
||
| Args: | ||
| config: The configuration for the processor. | ||
| chat_template_kwargs: The optional kwargs to pass to apply_chat_template. | ||
| preprocess: An optional lambda function that takes a row (dict) as input | ||
| and returns a preprocessed row (dict). The output row must contain the | ||
| required fields for the following processing stages. | ||
| postprocess: An optional lambda function that takes a row (dict) as input | ||
| and returns a postprocessed row (dict). | ||
| preprocess_map_kwargs: Optional kwargs to pass to Dataset.map() for the | ||
| preprocess stage (e.g., num_cpus, memory, concurrency). | ||
| postprocess_map_kwargs: Optional kwargs to pass to Dataset.map() for the | ||
| postprocess stage (e.g., num_cpus, memory, concurrency). | ||
| telemetry_agent: An optional telemetry agent for collecting usage telemetry. | ||
|
|
||
| Returns: | ||
| The constructed processor. | ||
| """ | ||
| ray.init(runtime_env=config.runtime_env, ignore_reinit_error=True) | ||
|
|
||
| stages = [] | ||
|
|
||
| # Prepare processor defaults for merging into stage configs | ||
| processor_defaults = { | ||
| "batch_size": config.batch_size, | ||
| "concurrency": config.concurrency, | ||
| "runtime_env": config.runtime_env, | ||
| "model_source": config.model_source, | ||
| } | ||
|
|
||
| # Resolve and build ChatTemplateStage if enabled | ||
| chat_template_stage_cfg = resolve_stage_config( | ||
| config.chat_template_stage, | ||
| ChatTemplateStageConfig, | ||
| processor_defaults, | ||
| ) | ||
| if chat_template_stage_cfg.enabled: | ||
| stages.append( | ||
| ChatTemplateStage( | ||
| fn_constructor_kwargs=dict( | ||
| model=chat_template_stage_cfg.model_source, | ||
| chat_template=get_value_or_fallback( | ||
| chat_template_stage_cfg.chat_template, config.chat_template | ||
| ), | ||
| chat_template_kwargs=get_value_or_fallback( | ||
| chat_template_stage_cfg.chat_template_kwargs, | ||
| chat_template_kwargs, | ||
| ), | ||
| ), | ||
| map_batches_kwargs=build_cpu_stage_map_kwargs(chat_template_stage_cfg), | ||
| ) | ||
| ) | ||
|
|
||
| # Resolve and build TokenizeStage if enabled | ||
| tokenize_stage_cfg = resolve_stage_config( | ||
| getattr(config, "tokenize_stage", config.tokenize), | ||
| TokenizerStageConfig, | ||
| processor_defaults, | ||
| ) | ||
| if tokenize_stage_cfg.enabled: | ||
| stages.append( | ||
| TokenizeStage( | ||
| fn_constructor_kwargs=dict( | ||
| model=tokenize_stage_cfg.model_source, | ||
| ), | ||
| map_batches_kwargs=build_cpu_stage_map_kwargs(tokenize_stage_cfg), | ||
| ) | ||
| ) | ||
|
|
||
| # Core stage -- the SGLang engine. | ||
| stages.append( | ||
| SGLangEngineStage( | ||
| fn_constructor_kwargs=dict( | ||
| model=config.model_source, | ||
| engine_kwargs=config.engine_kwargs, | ||
| task_type=config.task_type, | ||
| max_pending_requests=config.max_pending_requests, | ||
| ), | ||
| map_batches_kwargs=dict( | ||
| zero_copy_batch=True, | ||
| # The number of running replicas. This is a deprecated field, but | ||
| # we need to set `max_tasks_in_flight_per_actor` through `compute`, | ||
| # which initiates enough many overlapping UDF calls per actor, to | ||
| # saturate `max_concurrency`. | ||
| compute=ray.data.ActorPoolStrategy( | ||
| **config.get_concurrency(autoscaling_enabled=True), | ||
| max_tasks_in_flight_per_actor=config.experimental.get( | ||
| "max_tasks_in_flight_per_actor", DEFAULT_MAX_TASKS_IN_FLIGHT | ||
| ), | ||
| ), | ||
| # The number of running batches "per actor" in Ray Core level. | ||
| # This is used to make sure we overlap batches to avoid the tail | ||
| # latency of each batch. | ||
| max_concurrency=config.max_concurrent_batches, | ||
| accelerator_type=config.accelerator_type, | ||
| runtime_env=config.runtime_env, | ||
| ), | ||
| ) | ||
| ) | ||
|
|
||
| # Resolve and build DetokenizeStage if enabled | ||
| detokenize_stage_cfg = resolve_stage_config( | ||
| getattr(config, "detokenize_stage", config.detokenize), | ||
| DetokenizeStageConfig, | ||
| processor_defaults, | ||
| ) | ||
| if detokenize_stage_cfg.enabled: | ||
| stages.append( | ||
| DetokenizeStage( | ||
| fn_constructor_kwargs=dict( | ||
| model=detokenize_stage_cfg.model_source, | ||
| ), | ||
| map_batches_kwargs=build_cpu_stage_map_kwargs(detokenize_stage_cfg), | ||
| ) | ||
| ) | ||
|
|
||
| hf_config = transformers.AutoConfig.from_pretrained(config.model_source) | ||
| architecture = getattr(hf_config, "architectures", [DEFAULT_MODEL_ARCHITECTURE])[0] | ||
|
|
||
| telemetry_agent = get_or_create_telemetry_agent() | ||
| telemetry_agent.push_telemetry_report( | ||
| BatchModelTelemetry( | ||
| processor_config_name=type(config).__name__, | ||
| model_architecture=architecture, | ||
| batch_size=config.batch_size, | ||
| accelerator_type=config.accelerator_type or DEFAULT_GPU_TYPE, | ||
| concurrency=config.concurrency, | ||
| task_type=config.task_type, | ||
| tensor_parallel_size=config.engine_kwargs.get("tp_size", 1), | ||
| data_parallel_size=config.engine_kwargs.get("dp_size", 1), | ||
| ) | ||
| ) | ||
|
|
||
| processor = Processor( | ||
| config, | ||
| stages, | ||
| preprocess=preprocess, | ||
| postprocess=postprocess, | ||
| preprocess_map_kwargs=preprocess_map_kwargs, | ||
| postprocess_map_kwargs=postprocess_map_kwargs, | ||
| ) | ||
| return processor | ||
|
|
||
|
|
||
| ProcessorBuilder.register(SGLangEngineProcessorConfig, build_sglang_engine_processor) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file appears to be a direct copy of
sglang_engine_proc.pyand is not adapted for TensorRT-LLM. All references, from module docstrings and imports to class names (SGLangEngineProcessorConfig), function names (build_sglang_engine_processor), and internal logic, are for SGLang. The entire file needs to be refactored to implement the processor for the TensorRT-LLM engine.