Skip to content

Whitespace is ignored #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
denis-sokolov opened this issue Dec 13, 2016 · 1 comment
Closed

Whitespace is ignored #10

denis-sokolov opened this issue Dec 13, 2016 · 1 comment

Comments

@denis-sokolov
Copy link

Empty text nodes are explicitly discarded. However, that is clearly wrong in some cases. Perhaps we should only collapse whitespace, but not discard it?

Before parsing:
<p><span>Hello,</span> <span>world!</span></p>
After parsing:
<p><span>Hello,</span><span>world!</span></p>

#9 provides an opt-in solution, but perhaps this should not be opt-in?

@rayd
Copy link
Owner

rayd commented Jul 24, 2017

This should be resolved by #9 and this commit: 99d99ec. The default now is for us to collapse whitespace, not ignore it. Since this was a potentially breaking change, I've updated the major version number to 2.

@rayd rayd closed this as completed Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants