Require rayon-core ^1.4.1 #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayon-core 1.4.0 doesn't build with `cargo -Z minimal-versions`
Member
|
bors r+ I'm approving this, because it's harmless, but I do feel some objection to this in principle. The semantic requirement is correct at 1.4, and it's not our fault (nor yours) that deeper indirect dependencies got their minimum wrong. IMO it's problematic that Practically speaking, we're going to need a synchronized version bump of rayon and rayon-core before we publish anyway, because there are new re-exports from #615. |
bors bot
added a commit
that referenced
this pull request
Mar 3, 2019
641: Require rayon-core ^1.4.1 r=cuviper a=kornelski I'm trying to make my crates work with `cargo -Z minimal-versions` to ensure that versions specified in my Cargo.toml are actual versions that work with my crate. The problem is, it's not true for Rayon's dependencies: rayon 1.0.3 uses rayon-core 1.4.0, which uses rand 0.3.12, which uses advapi32-sys 0.1.2, which uses winapi 0.0.1, which isn't compatible with Rust 1.0. The problem has been fixed in rayon-core 1.4.1, so that should be the minimal version used by rayon. Co-authored-by: Kornel <[email protected]>
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to make my crates work with
cargo -Z minimal-versionsto ensure that versions specified in my Cargo.toml are actual versions that work with my crate.The problem is, it's not true for Rayon's dependencies: rayon 1.0.3 uses rayon-core 1.4.0, which uses rand 0.3.12, which uses advapi32-sys 0.1.2, which uses winapi 0.0.1, which isn't compatible with Rust 1.0.
The problem has been fixed in rayon-core 1.4.1, so that should be the minimal version used by rayon.