Skip to content

Add methods to Transport to read and write config space, rather than returning a pointer. #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qwandor merged 2 commits into from
Nov 22, 2024

Return Result from config space read/write methods.

3bcb721
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Add methods to Transport to read and write config space, rather than returning a pointer. #163

Return Result from config space read/write methods.
3bcb721
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Nov 21, 2024 in 0s

clippy

2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 2
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511e 2024-10-15)

Annotations

Check warning on line 374 in src/device/sound.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7) 

warning: this function has too many arguments (8/7)
   --> src/device/sound.rs:365:5
    |
365 | /     pub fn pcm_set_params(
366 | |         &mut self,
367 | |         stream_id: u32,
368 | |         buffer_bytes: u32,
...   |
373 | |         rate: PcmRate,
374 | |     ) -> Result {
    | |_______________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 265 in src/device/gpu.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7) 

warning: this function has too many arguments (8/7)
   --> src/device/gpu.rs:256:5
    |
256 | /     fn update_cursor(
257 | |         &mut self,
258 | |         resource_id: u32,
259 | |         scanout_id: u32,
...   |
264 | |         is_move: bool,
265 | |     ) -> Result {
    | |_______________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default
View more details on GitHub Actions