Remove DeviceType::Invalid and make conversion fallible #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the API by making invalid device types unrepresentable; APIs that need to represent a potentially failed conversion should use Option or Result instead. The MMIO transport is modified slightly to read the device ID up front (like the PCI transport). This also makes it impossible to construct a Transport instance for an unknown/unsupported DeviceType, which seems like a reasonable trade-off to me; it would also be possible to support such a scenario by making Transport::device_type() return Option<DeviceType> instead, but that would make the API clunkier to use.
qwandor
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the API by making invalid device types unrepresentable; APIs that need to represent a potentially failed conversion should use Option or Result instead.
The MMIO transport is modified slightly to read the device ID up front (like the PCI transport).
This also makes it impossible to construct a Transport instance for an unknown/unsupported DeviceType, which seems like a reasonable trade-off to me; it would also be possible to support such a scenario by making Transport::device_type() return Option instead, but that would make the API clunkier to use.