Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

add a function to log in a compact format #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented Oct 2, 2014

a more compact display of 1 line per metric, and all times in ms.

with Log() the output was super overwhelming to me.

@rcrowley
Copy link
Owner

rcrowley commented Oct 5, 2014

Any reason not to use the same format as in syslog.go?

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Oct 8, 2014

whoa, i hadn't seen syslog.go; looks very similar indeed.
however syslog.go:

  • it still seems to use nanoseconds, which makes the numbers very big and hard to read if the number is in the order of tens or hundreds of ms
  • it includes every single dimension/percentile, which is also too much info for my case.

then again the format in this PR will often also not be exactly what people want. maybe we should make it easier for people to dynamically build a log function that logs in the format they want.

@mihasya
Copy link
Collaborator

mihasya commented Jul 4, 2015

Wonder if a MetricFormatter interface needs to be introduced with a default implementation using text/template

@mihasya mihasya added the feature label Jul 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants