support serving up go-metrics as expvars

[Dieterbe]

not thoroughly tested yet, but seems to work fine so far.

[mihasya]

Can we make this endpoint configurable?

[Dieterbe]

what would be the point of introducing variability for this?
it makes more sense to me IMHO to have some sort of "convention" for the address of a "go-metrics enabled expvar page". one thing is for sure: I couldn't find a way to take over/use
/debug/vars. Actually now that I think about it, /debug/vars is also fixed for convention, which I think is a good thing.

[mihasya]

That's a good point. Then how about just 'debug/metrics'? I'm generally not
a fan of adding numbers to variable names and urls where there's an
opportunity to have a meaningful name.

On Saturday, July 4, 2015, Dieter Plaetinck notifications@github.com
wrote:

In exp/exp.go
#96 (comment):

•   if !first {
  

•       fmt.Fprintf(w, ",\n")
  

•   }
  

•   first = false
  

•   fmt.Fprintf(w, "%q: %s", kv.Key, kv.Value)
  

• })
• fmt.Fprintf(w, "\n}\n")
  +}

+func Exp(r metrics.Registry) {

• e := exp{sync.Mutex{}, r}
• // this would cause a panic:
• // panic: http: multiple registrations for /debug/vars
• // http.HandleFunc("/debug/vars", e.expHandler)
• // haven't found an elegant way, so just use a different endpoint
• http.HandleFunc("/debug/vars2", e.expHandler)

what would be the point of introducing variability for this?
it makes more sense to me IMHO to have some sort of "convention" for the
address of a "go-metrics enabled expvar page". one thing is for sure: I
couldn't find a way to take over/use
/debug/vars. Actually now that I think about it, /debug/vars is also
fixed for convention, which I think is a good thing.

—
Reply to this email directly or view it on GitHub
https://github.com/rcrowley/go-metrics/pull/96/files#r33890766.

Sent from Russia, with love. But also from my phone.

[sargun]

Any reason why this didn't get merged?

[mihasya]

Yes, but no relevant ones. Everyone involved in maintaining this repo has
had a pretty intense month or two (acquisitions, babies, etc), so reviews
have not been timely. Hoping to get caught up tomorrow.

On Friday, November 13, 2015, Sargun Dhillon notifications@github.com
wrote:

Any reason why this didn't get merged?

—
Reply to this email directly or view it on GitHub
#96 (comment).

Sent from Russia, with love. But also from my phone.

[Dieterbe]

sounds like very good reasons to me. congrats to the babies and acquisitions everyone ;)

[mihasya]

OK finally getting back to this. I still would like to see a URL that was something more descriptive than vars2 - /debug/metrics or something like that. Variables with numbers at the end are a code smell, and IMO so are URLs. Otherwise, this is good to go. Thank you for your patience.

[Dieterbe]

there you go ^^

[ghost]

Is there anything I can do to help with in order to get this merged?

[dzlab]

why this is not yet on master??

[mihasya]

I keep forgetting to click merge. At the office in ~10, will click.

On Wednesday, January 13, 2016, El-Soufy notifications@github.com wrote:

why this is not yet on master??

—
Reply to this email directly or view it on GitHub
#96 (comment).

Sent from Russia, with love. But also from my phone.