Simplify callbacks #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 95f1e31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tpluscode
commented
Jul 6, 2021
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@rdfjs/types": minor | |||
There was a problem hiding this comment.
Not sure whether this should be minor or patch. It's a significant change but maybe still just a bug fix?
There was a problem hiding this comment.
I'm ok with classifying it as minor
|
The problem seems to stem from the spec, could this have been a limitation of WebIDL? https://rdf.js.org/dataset-spec/#quadfilteriteratee-interface |
|
Possibly. And apparently it got translated to TS verbatim |
blake-regalia
approved these changes
Jul 10, 2021
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@rdfjs/types": minor | |||
There was a problem hiding this comment.
I'm ok with classifying it as minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by Blake's message on Gitter I thought I would take a second look and apparently the current types are imperfect
By inlining the callback/iteratee functions, the correct type of
datasetargument can be used.