Skip to content

fix: usage with node module resolution#63

Open
tpluscode wants to merge 1 commit intomasterfrom
module-resolution-nodenext
Open

fix: usage with node module resolution#63
tpluscode wants to merge 1 commit intomasterfrom
module-resolution-nodenext

Conversation

@tpluscode
Copy link
Copy Markdown
Member

I'm not sure how this was never raised as issue, and maybe I'm brainfogged right now

In a new project, I set moduleResolution to nodenext and this breaks the types package because all imports must have .js extension.

This should fix...

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 24, 2026

🦋 Changeset detected

Latest commit: 364adbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rdfjs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tpluscode
Copy link
Copy Markdown
Member Author

Ok to merge?

@tpluscode
Copy link
Copy Markdown
Member Author

On second thought, maybe I can try to reflect this in a more robust test matrix to check the types work given various combination of TS settings...

@tpluscode
Copy link
Copy Markdown
Member Author

And of course, running tsc with various combinations of options works every time in the types repo 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants