fix: correctly list ios devices and simulators #1823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
approved these changes
Feb 7, 2023
Collaborator
szymonrybczak
left a comment
szymonrybczak
left a comment
There was a problem hiding this comment.
Perfect work @adamTrz! 🙌
Co-authored-by: Szymon Rybczak <[email protected]>
Co-authored-by: Szymon Rybczak <[email protected]>
adamTrz
force-pushed
the
fix-list-ios-devices
branch
from
40027ba to
6dcd752
Compare
Member
|
Can you check if |
Collaborator
Author
It's working on xCode 12 and 13, couldn't get my hands on lower versions yet ... |
Member
|
Awesome! That's more than enough I think :D |
This was referenced Mar 8, 2023
This was referenced May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Switched from
xcrun xctrace list devicestoxcrun xcdevice listwhen gathering info about available iOS devices and simulators.Previous one wasn't providing enough information to distinguish between AppleTV / macOS / iPhone devices leading to unexpected behaviours.
Fixes #1816
Fixes #1807
Closes #1786
Test Plan:
Connect as many Apple devices as possible and:
run-ios- it should try to launch RN App on all valid devices and simulatorsrun-ios --list-devices- it should list all valid devices (even not available ones) and simulators