Skip to content

refactor: remove useless parameter #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thymikee merged 1 commit into from
Apr 17, 2023
Merged

refactor: remove useless parameter #1906

thymikee merged 1 commit into from
Apr 17, 2023

Conversation

@FE-Sadhu
Copy link
Contributor

@FE-Sadhu FE-Sadhu commented Apr 11, 2023

Summary:

  • since this change was merged, the parameter directory of function installPods is useless. So I removed.

Test Plan:

  • use init command, still work fine.
  • image

adamTrz
adamTrz approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@adamTrz adamTrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

szymonrybczak
szymonrybczak approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@thymikee thymikee merged commit ef9b2fc into react-native-community:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamTrz adamTrz adamTrz approved these changes

@szymonrybczak szymonrybczak szymonrybczak approved these changes

@thymikee thymikee Awaiting requested review from thymikee thymikee is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FE-Sadhu @adamTrz @szymonrybczak @thymikee