Skip to content

fix: Adjust wording for dev server port taken messages #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Sep 11, 2023
Merged

fix: Adjust wording for dev server port taken messages #2067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli-tools/src/handlePortUnavailable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const handlePortUnavailable = async (
port = nextPort;
} else {
packager = false;
logChangePortInstructions(port);
logChangePortInstructions();
}
}

Expand Down
13 changes: 6 additions & 7 deletions packages/cli-tools/src/port.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import {prompt} from './prompt';
import logger from './logger';
import chalk from 'chalk';

export const askForPortChange = async (port: number, nextPort: number) => {
logger.info(
`Metro is already running on port ${chalk.bold(port)} in another project.`,
);
logger.info(`Another process is running on port ${port}.`);
return await prompt({
name: 'change',
type: 'select',
Expand All @@ -18,11 +15,13 @@ export const askForPortChange = async (port: number, nextPort: number) => {
};

export const logAlreadyRunningBundler = (port: number) => {
logger.info(`Metro Bundler is already for this project on port ${port}.`);
Copy link
Collaborator Author

@huntie huntie Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Fixes typo!

logger.info(
`A dev server is already running for this project on port ${port}.`,
);
};

export const logChangePortInstructions = (port: number) => {
export const logChangePortInstructions = () => {
logger.info(
`Please close the other packager running on port ${port}, or select another port with "--port".`,
'Please terminate this process and try again, or use another port with "--port".',
);
};