Skip to content

fix: add more guard conditions for retrieving buildConfig from XcScheme #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 3 commits into from
Dec 18, 2023
+3 −1
Merged

fix: add more guard conditions for retrieving buildConfig from XcScheme #2196

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c8bb12
fix: add more guard conditions for retrieving buildConfig from XcScheme
AnnatarHe Dec 7, 2023
14560bc
fix: mark unused variable as _
AnnatarHe Dec 13, 2023
bdb77e5
fix: revert code and add more info
AnnatarHe Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/cli-platform-ios/src/tools/getBuildConfigurationFromXcScheme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@ export function getBuildConfigurationFromXcScheme(
sourceDir: string,
projectInfo: IosInfo | undefined,
): string {
// can not assume .xcodeproj exists.
// for more info see: https://github.com/react-native-community/cli/pull/2196
try {
const xcProject = fs
.readdirSync(sourceDir)
.find((dir) => dir.includes('.xcodeproj'));
.find((dir) => dir.endsWith('.xcodeproj'));

if (xcProject) {
const xmlScheme = fs.readFileSync(
Expand Down