Skip to content

fix: remove automatic config file generation #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thymikee merged 1 commit into from
Dec 13, 2023
Merged

fix: remove automatic config file generation #2203

thymikee merged 1 commit into from
Dec 13, 2023

Conversation

@okwasniewski
Copy link
Contributor

@okwasniewski okwasniewski commented Dec 13, 2023 •
edited by thymikee
Loading

Summary:

This PR removes automatic config file generation during the init command.

Relates to #2202

Test Plan:

Run init command and test if it doesn't generate react-native.config.js

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee
Copy link
Member

thymikee commented Dec 13, 2023

We need to update this snapshot:

image

@thymikee thymikee merged commit 6b8607c into react-native-community:main Dec 13, 2023
@okwasniewski okwasniewski deleted the fix/config-generation branch December 13, 2023 10:19
thymikee pushed a commit that referenced this pull request Dec 13, 2023
@okwasniewski @thymikee
fix: remove automatic config file generation (#2203)
ffacf4d
This was referenced Dec 18, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TMisiukiewicz TMisiukiewicz TMisiukiewicz approved these changes

@adamTrz adamTrz Awaiting requested review from adamTrz

@thymikee thymikee Awaiting requested review from thymikee thymikee is a code owner

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@okwasniewski @thymikee @TMisiukiewicz