Skip to content

Conversation

@szymonrybczak
Copy link
Collaborator

@szymonrybczak szymonrybczak commented Dec 18, 2023

Summary:

It may be confusing when we throw an error while initialising Git repo, let's just don't give any information since isn't not-blocking thing. Reference: #2212

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Put throw new Error('Git commit failed'); on 57th line in createGitRepository.ts file.
  3. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js init

Git repo init loader shouldn't be presented.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actions github-actions bot added the infra Internal work not facing public APIs label Dec 18, 2023
@szymonrybczak szymonrybczak changed the title chore(init): remove error when command failed chore(init): remove error when Git initialisation failed Dec 18, 2023
@thymikee thymikee merged commit 49426fd into main Dec 20, 2023
@thymikee thymikee deleted the chore/remove-erorr-when-git-init-failed branch December 20, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Internal work not facing public APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants