Fix: cleaning metro cache #2258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TMisiukiewicz
force-pushed
the
fix/clean-metro-cache
branch
from
bcf6c5a to
a96ceb3
Compare
szymonrybczak
approved these changes
Jan 12, 2024
Collaborator
szymonrybczak
left a comment
szymonrybczak
left a comment
There was a problem hiding this comment.
Works great on two platforms, LGTM 🙌
thymikee
reviewed
Jan 15, 2024
Comment on lines
+42
to
+48
| glob(directory, {}, (err, foundDirectories) => { | ||
| if (err) { | ||
| reject(err); | ||
| } else { | ||
| resolve(foundDirectories); | ||
| } | ||
| }); |
Member
There was a problem hiding this comment.
doesn't glob have its promise interface?
Collaborator
Author
There was a problem hiding this comment.
it does, but starting from 9.0, and we are currently using 7.x across the project 😢
Member
There was a problem hiding this comment.
Let's upgrade it in a separate PR :D
thymikee
approved these changes
Jan 15, 2024
TMisiukiewicz
force-pushed
the
fix/clean-metro-cache
branch
from
a96ceb3 to
561d449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
fs.rmfunction does not expand, so when usingcleancommand, Metro files are not removed.This is a follow-up PR to #2161 which solves this problem for Windows, but since
fs.rmdoes not expand at all, it still doesn't work properly for macOS. Removing OS check in this solution does not solve the issue, probably becauseconvertPathToPatternfromfast-globmodifies the pattern frommetro-*tometro-\*. This PR should work correctly on both operating systems.Closes #2161
Test Plan:
os.tmpdir())startcommand in any CLI applsin the temp directory to verify anymetro-*are listedcleancommand, selectmetrooption and confirmlsin the temp directory again and verify allmetro-*are goneChecklist