Skip to content

optional dependency canvas breakes CI builds #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
handjunyoung opened this issue Jul 11, 2017 · 3 comments
Closed

optional dependency canvas breakes CI builds #160

handjunyoung opened this issue Jul 11, 2017 · 3 comments

Comments

@handjunyoung
Copy link

After #141 , there added canvas package into optionalDependencies

However, it breakes npm install or yarn install since prerequisites (such as cario, gpp, etc) is not available in CI execution environments.

Please look into it
@jerairrest
Copy link
Collaborator

hmm... shouldn't canvas-prebuilt work as a fallback? Are you getting a specific error related to canvas?

@Viral-Inc
Copy link

+1

@jerairrest
Copy link
Collaborator

Fixed in https://github.com/jerairrest/react-chartjs-2/releases/tag/2.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jerairrest @Viral-Inc @handjunyoung