Skip to content

Use cross-env to enable windows build #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2017

Conversation

acailly
Copy link

@acailly acailly commented Jun 7, 2017

Setting env vars like this NODE_ENV=production doesn't works on Windows.

Using cross-env fixes this issue: cross-env NODE_ENV=production

Note that I didn't update yarn.lock file because I'm not able to do a full install due to canvas dependency build failure

@acailly acailly force-pushed the windows-build branch 3 times, most recently from 1a58931 to 1aad08e Compare June 28, 2017 15:13
@acailly
Copy link
Author

acailly commented Jun 28, 2017

To make it work, I put canvas as an optional dependency and added canvas -prebuilt dependency
If the tests don't find canvas, they will now use canvas-prebuilt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants