Skip to content

Update to support macOS-latest runners (and even windows experimentally) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

reactive-firewall
Copy link
Owner

@reactive-firewall reactive-firewall commented Dec 22, 2024

Removed Linux-only limit for runners

Fix for supporting MacOS runners

Cause: shellcheck is not installed by default on macOS-latest runners and needs to be installed.
Solution: add runner-os based setup steps for example using brew to install shellcheck on macOS.

Specific Changes

action.yml:

  • Added steps to install ShellCheck on macOS using brew.
  • Added steps to install ShellCheck on Windows using Chocolatey.
  • Updated the existing installation steps for ShellCheck Scan dependencies to use printf for better readability and added conditions to differentiate between operating systems.
  • Introduced experimental steps for installing dependencies on Windows.

These changes ensure that ShellCheck is correctly installed on both macOS and Windows runners, improving the cross-platform compatibility of the action.

  🤔  oh and I might have out-done my self with a little help from co-pilot.
@reactive-firewall reactive-firewall linked an issue Dec 22, 2024 that may be closed by this pull request
@reactive-firewall reactive-firewall self-assigned this Dec 22, 2024
Copy link
Owner Author

@reactive-firewall reactive-firewall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! MacOS runners work now.

@reactive-firewall reactive-firewall merged commit 89ae54c into master Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE - support setup via brew for macos runners
1 participant