fix Bind with Trigger reinstated ViewToViewModel added option #2867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added TriggerUpdate option to Bind with Trigger to choose which direction the update will occur. TriggerUpdate default is ViewToViewModel which uses original functionality. Added tests
Codecov Report
@@ Coverage Diff @@
## main #2867 +/- ##
==========================================
- Coverage 72.10% 71.57% -0.53%
==========================================
Files 137 139 +2
Lines 4828 4890 +62
==========================================
+ Hits 3481 3500 +19
- Misses 1347 1390 +43
Continue to review full report at Codecov.
|
Issue with GitHub Actions causing build failure, was thinking was issue with DiffEngine 7.1.0
Add DecimalToStringTypeConverter and DoubleToStringTypeConverter Add test for Bind with trigger and type converter
glennawatson
approved these changes
Aug 10, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix #2861 reinstate ViewToViewModel trigger
feature can now choose the direction the trigger will affect
What is the current behaviour?
after #2772 the trigger was fixed to match a test incorrectly, v14.1 and v14.2 have the ViewModelToView implementation which is the reverse of the correct functionality according to the documentation.
What is the new behaviour?
Added the ability to choose the direction with the default being ViewToViewModel as per the documentation
What might this PR break?
those who have used the ViewModelToView implementation in V14.1 and V14.2 will need to specify the direction in the binding as TriggerUpdate.ViewModelToView.
Please check if the PR fulfils these requirements
Other information: