-
Notifications
You must be signed in to change notification settings - Fork 131
Translated your first component #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translated your first component #204
Conversation
@arshadkazmi42 please review this pull request Thank You |
@Akshit1025 I have been a bit busy. I will get to it soon. Sorry about the delay |
ok no problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this.
I have added few comments till line 55
Lets' get these fixed and then I will continue with further review.
You can check for our review guidelines at #23
@arshadkazmi42 Hey, I have changed all the typos that you have suggested till now. You can start reviewing further Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the fixes.
I have added more review comments till line 170.
Let's get these fixed, post that we can continue further with the review
@arshadkazmi42 I have fixed the typos and now you can further review the translation |
@Akshit1025 There are two review comments which still have minor issues. Rest looks fine. I have marked them as unresolved, can you check and update those? Post that we can continue further. |
@Akshit1025 There is still one typo in the code block. Please check the unresolved comment |
@arshadkazmi42 typos have been fixed. Please carry on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the fixes.
I have added review in rest of the file.
Once these are fixed we can get this merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the fixes.
I have added review in rest of the file.
Once these are fixed we can get this merged.
@arshadkazmi42 all the typos that you have suggested have been completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Thank you for working on all the fixes.
lets get this merged 🎉
I have translated the Your First Component page. Please review it
Sections on the page
Please let me know if there are any changes that have to be made
Please checkmark these boxes too
Thank You