Skip to content

Add React to a Website #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Add React to a Website #65

wants to merge 9 commits into from

Conversation

NorinMp143
Copy link

No description provided.

@netlify
Copy link

netlify bot commented Jan 10, 2020

Deploy preview for hi-reactjs ready!

Built with commit 3edd189

https://deploy-preview-65--hi-reactjs.netlify.com

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start.
added some review
You can read about our review process here #23

I will continue the review once these feedbacks are fixed

@@ -1,35 +1,34 @@
---
id: add-react-to-a-website
title: Add React to a Website
title: React को Website से जोड़े
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

से जोड़े => ऐड करें

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I'll change this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

करे => करें

minor spelling mistake -> missing dot

permalink: docs/add-react-to-a-website.html
redirect_from:
- "docs/add-react-to-an-existing-app.html"
prev: getting-started.html
next: create-a-new-react-app.html
---
अपनी आवश्यकता के अनुसार कम या ज्यादा React का उपयोग करें
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add line break at line 10

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not done yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pending


There will be no complicated tools or install requirements -- **to complete this section, you only need an internet connection, and a minute of your time.**
यहाँ कोई जटिल उपकरण नहीं होगा या आवश्यकताओं को स्थापित( इनस्टॉल ) नहीं किया जाएगा -- **इस अनुभाग को पूरा करने के लिए, आपको केवल एक इंटरनेट कनेक्शन और आपके समय का एक मिनट चाहिए।**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

स्थापित( इनस्टॉल ) => इनस्टॉल

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you missed this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have missed this

Copy link
Author

@NorinMp143 NorinMp143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done with all the changes!

@arshadkazmi42 arshadkazmi42 added the 1st Review First phase of review label Jan 24, 2020
@arshadkazmi42
Copy link
Member

@NorinMp143 Good work with the fixes. You have missed a couple of fixes. Once those are fixed we will continue further.

Also, just a small review, do not mark review comment as resolved. Reviewer will review the fix and mark the feedback as resolved

@arshadkazmi42
Copy link
Member

@NorinMp143 There are couple of pending feedbacks. Please check above this comment. All the unresolved feedbacks

@arshadkazmi42
Copy link
Member

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants