Skip to content

Translate "Writing markup with jsx" page #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 27, 2023

Conversation

Ago95Dev
Copy link
Contributor

Italian translation for "Writing markup with jsx" page and sidebar entry.

(I'm newbie, not sure if i did all alright.)

Part of #418

Ago95Dev and others added 3 commits April 26, 2023 19:38
Tradotto fino a sezione 3 regola camelCase
Da revisionare
Tradotto "Writing Markup with JSX" e relativa voce nella sidebar Learn
Copy link
Collaborator

@mattia-sanfilippo mattia-sanfilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie mille @Ago95Dev !! 🚀
Ho lasciato qualche commento, facci sapere cosa ne pensi 💪🏻

Ago95Dev and others added 3 commits April 27, 2023 11:16
Co-authored-by: Mattia Sanfilippo <[email protected]>

Co-authored-by: Mattia Sanfilippo <[email protected]>
Co-authored-by: Mattia Sanfilippo <[email protected]>

Co-authored-by: Mattia Sanfilippo <[email protected]>
Co-authored-by: Mattia Sanfilippo <[email protected]>

Co-authored-by: Mattia Sanfilippo <[email protected]>
@Ago95Dev
Copy link
Contributor Author

Ago95Dev commented Apr 27, 2023

Grazie mille @Ago95Dev !! 🚀 Ho lasciato qualche commento, facci sapere cosa ne pensi 💪🏻

Suggerimenti applicati, ty per gli ottimi feedback

@@ -92,7 +93,7 @@ export default function TodoList() {
}
```

If you copy and paste it as is, it will not work:
Se lo copiamo e incolliamo così com'è, non funzionerà:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Se lo copiamo e incolliamo così com'è, non funzionerà:
Copiandolo e incollandolo così com'è, non funzionerà:

@Ago95Dev leggendo l'intera frase, comprese le due righe precedenti, sembra suonar meglio, ma onestamente non sono convinto al 100% della soluzione che ti ho proposto 🤔
Tu cosa ne pensi?

Copy link
Contributor Author

@Ago95Dev Ago95Dev Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo leggo più facilmente nel primo modo, però non sono esperto di traduzioni, se ritieni migliore il cambiamento lo commitiamo.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Va bene anche così 😄

@mattia-sanfilippo
Copy link
Collaborator

Grazie mille @Ago95Dev !! 🚀 Ho lasciato qualche commento, facci sapere cosa ne pensi 💪🏻

Suggerimenti applicati, ty per gli ottimi feedback

Grazie a te!! 😄 💪

Ho soltanto proposto una correzione in più per quanto riguarda uno spazio mancante dopo HTML e invece un dubbio per quanto riguarda una spiegazione divisa in più step, ma non sono ancora convinto di quest'ultima. Tu cosa ne pensi? :)

Copy link
Collaborator

@mattia-sanfilippo mattia-sanfilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie! 🚀

Ho proposto la rimozione di una linea vuota che nell'originale non è presente, per il resto secondo me è ottima 🙂

Copy link
Collaborator

@deblasis deblasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ottimo lavoro @Ago95Dev!
Salutami la mia terra, sono Marsicano d'origine :)

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.41 KB (🟡 +1 B) 170.04 KB
/500 76.41 KB (🟡 +1 B) 170.04 KB
/[[...markdownPath]] 77.83 KB (🟡 +1 B) 171.46 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@deblasis deblasis merged commit 08d1509 into reactjs:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants