Skip to content

Translate: State as a snapshot page #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 30, 2023

Conversation

NeilChavez
Copy link
Contributor

Hi!
Here is my contribution :)

  • Translation of page content.
  • Translation of page title in sidebarLearn.json.

See #418

Copy link
Collaborator

@mattia-sanfilippo mattia-sanfilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao @NeilChavez, grazie per il contributo! :)

Ho suggerito alcune modifiche da apportare, alcuni errori di ortografia e la modifica di stato in state, perché secondo le linee guida non va mai tradotto.

Fammi sapere cosa ne pensi. Grazie! 🚀

Co-authored-by: Mattia Sanfilippo <[email protected]>
@NeilChavez
Copy link
Contributor Author

Ciao @mattia-sanfilippo!
Sono d'accordo con le modifiche che hai suggerito. Le ho applicate. 👍
Grazie per esserti preso il tempo di fare la review. 🚀

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 75.81 KB (🟡 +10 B) 178.97 KB
/500 75.81 KB (🟡 +10 B) 178.96 KB
/[[...markdownPath]] 77.24 KB (🟡 +10 B) 180.4 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@mattia-sanfilippo mattia-sanfilippo merged commit 4dce0b1 into reactjs:main May 30, 2023
@NeilChavez NeilChavez deleted the state-as-a-snapshot branch May 30, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants