Skip to content

[fixed] check before react-modal removal from parent element that par… #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

dremlin2000
Copy link

Fixes #820.

Changes proposed:
Check if this.node element exists in parent element before removal

Upgrade Path (for changed or removed APIs):
N/A

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.135% when pulling 1094ce1 on dremlin2000:bug/patch-1 into bd07d56 on reactjs:master.

@diasbruno diasbruno merged commit fa98fcc into reactjs:master Aug 19, 2020
@diasbruno
Copy link
Collaborator

Thanks, @dremlin2000!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Uncaught [NotFoundError: The node to be removed is not a child of this node.]
3 participants