Skip to content

Replace "caveat" with "warning"? #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kaycebasques opened this issue Oct 13, 2017 · 2 comments
Closed

Replace "caveat" with "warning"? #155

kaycebasques opened this issue Oct 13, 2017 · 2 comments
Labels
difficulty: beginner good first issue type: documentation

Comments

@kaycebasques
Copy link

Nice docs :)

Just a suggestion to replace "caveat", as seen here in Introducing JSX

>**Caveat:**
>
>Since JSX is closer to JavaScript than HTML, React DOM uses `camelCase` property naming convention instead of HTML attribute names.
>
>For example, `class` becomes [`className`](https://developer.mozilla.org/en-US/docs/Web/API/Element/className) in JSX, and `tabindex` becomes [`tabIndex`](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/tabIndex).

with a less-fancy / more straightforward word such as "warning"
@bvaughn
Copy link
Contributor

bvaughn commented Oct 13, 2017

Good suggestion. Would you be interested in submitting a PR for this?

charlottetan added a commit to charlottetan/reactjs.org that referenced this issue Oct 16, 2017
@charlottetan
Updating "caveat" to "warning"
7238d42 
Updating "caveat" to "warning" as suggested in reactjs#155
@charlottetan charlottetan mentioned this issue Oct 16, 2017
Merged
@bvaughn
Copy link
Contributor

bvaughn commented Oct 16, 2017

Fixed via PR #163

@bvaughn bvaughn closed this as completed Oct 16, 2017
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
@Luanf @glaucia86
Initial work on "Is React Translated Yet" blog post translation (reac…
33f628e 
…tjs#155)

* Initial work on "Is React Translated Yet" blog post translation

* Finish translation of is-react-translated-yet blog post

* Apply suggestions from code review

Co-Authored-By: Luanf <[email protected]>
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this issue Mar 21, 2023
@dear-lizhihua @QC-L
docs(cn): translate content/docs/reference-glossary.md into Chinese (r…
e47d538 
…eactjs#155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: beginner good first issue type: documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bvaughn @kaycebasques