-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Interactive documentation for JSX #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello guys, As a starter, here is the main value points and the concerns as I see it: Value to the readersthey can experiment with the code snippets without having to leave the page. Concernsthe size of the javascript files:
|
Those file sizes are valid concerns certainly. I think we could potentially do some things to mitigate them. On the Babel REPL (source code here) we do a couple of things to help with this:
|
Before reducing the footprint, would you like to give it a try on one or two pages of the react documentation and feel how it feels both on desktop and on mobile? |
I think it would be reasonable to put together a minimal proof-of-concept to see how the UX was before we worry too much about performance optimizations, sure. |
Hello guys, I've been working on an integration of Klipse using [gatsby-plugin-klipse] (https://github.com/ahmedelgabri/gatsby-plugin-klipse) written by @ahmedelgabri. Here is the Work-In-Progress pull request #236 |
I'm going to close this issue for now, for the reasons I mentioned in my comment on PR #236. I'm happy to keep talking about and re-evaluate any new ideas of proofs of concept though! ❤️ |
Sync with reactjs.org @ e3cf542
This issue was originally reported by @viebel via facebook/react/issues/10646:
The interactive version of the "JSX in depth" article got a nice traction today on Hacker News.
The interactive snippets are powered by the Klipse plugin (I'm the author of the plugin). The evaluation is done on the client side: no server is involved at all!
Would you consider trying the Klipse plugin on the official react documentation?
The text was updated successfully, but these errors were encountered: