-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Add ES5 example to Tutorial #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@M-ZubairAhmed that would've been helpful months ago :D Do you need the code in the JS panel of the pen? render is being called twice with no obvious reason why |
yes you are right I don't need one more render method. So does this solve the issue ? or should I include anything more. |
Is there anything else that needs to be done here? I'd be happy to finish it. |
@bvaughn Is this issue still in need of being completed? While I think some would find a non-ES6/JSX demo useful, it's now 2 years on since this issue was raised and ES6 is much more standard. |
It would be really helpful to see an ES5 example that uses functional components. |
* Translate Error Boundaries. * Fix typo on error boundaries. Co-Authored-By: fmoliveira <[email protected]> * Change 'cryptic' translation to a more usual synonym. Co-Authored-By: fmoliveira <[email protected]>
Hi, I'd like to contribute to this issue. Are there any remaining items that I can work on? |
This issue was originally reported by @quadruplejump via facebook/react/issues/10147
Text of original issue:
The tutorials, with the exception of the "advanced guides", assume ES6/JSX.
The React without ES6 tutorial https://facebook.github.io/react/docs/react-without-es6.html still uses JSX.
The React without JSX tutorial https://facebook.github.io/react/docs/react-without-jsx.html still uses ES6.
What would a simple ES5 React demo look like?
To compare, the Vue introduction https://vuejs.org/v2/guide/ starts with very simple examples that you can just drop in a webpage.
Note from Dan
We can probably add an intro paragraph to both of these pages that links to HTML page with minimal example.
Note from Brian
Pending the outcome of #122, it might be nice to host the new minimal example in the repo and display it in CodeSandbox/Codepen.
The text was updated successfully, but these errors were encountered: