-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Remove hard-coded HTML/CSS from index.md #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@bvaughn I would like to take up this task |
This issue is all yours! 😄 I've added an "in-progress" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim. Cheers! |
Got it. Thanks for the heads up! |
You're welcome! Sorry this took so long too 😓 Thanks for the follow up work (which made up the bulk of the PR actually 😂 ) |
No problem 😁 I'm pretty happy with the resulting solution so yay for us |
* update portals (translating to PT-BR) * update portals * Fix typos * Atualização de "Uso" para "Utilização" * Correção de erro de digitação * Correção de erro de digitação * Correção da tradução de "modal" * Correção de erro de digitação * Correção de plural * Atualização de "notar" para "observar" * atualização * Update portals.md
…ese (reactjs#97) Add Chinese translation for Test Renderer.
(This is a tech debt clean-up issue from the legacy Jekyll docs site.)
The
docs/index.md
file currently contains a lot of HTML- complete with attributes and class names. This file should contain only (or at least predominantly) markdown syntax. We should remove as much of the HTML as possible and instead convert it to regular markdown.There are 2 things to be aware of while cleaning up this markdown file:
home.js
template (see below).The
templates/home.js
template makes this situation a little more complex, since it currently uses some of the inline HTML elements fromindex.md
to mount examples (eg<div id="helloExample"></div>
). It might be acceptable to leave only these mount nodes in the file and remove all else.It might also be nice to break index down into a couple of files, although this would also require:
home.js
from templates to pages and creating a graphql query to load these filesgatsby-node.js
to ignore the files (so they aren't turned into standalone pages. (We have a similar check for the error decoder page.)Making Home a page instead of a template would also provide a nice solution for the horizontal scrolling problem mentioned above.
Also,
mountCodeExample
currently does some really hacky stuff. Making Home a page instead of a template could help us move some of that hackiness out and simplify things like showing a placeholder while pre-loading Babel (#2).Please feel free to chat with @bvaughn if you decide to pick up this issue.
The text was updated successfully, but these errors were encountered: