Recommmended PureComponent instead of shallowCompare #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 702fddd |
bvaughn
approved these changes
Oct 10, 2017
There was a problem hiding this comment.
I think it might be nicer to change the wording slightly:
We recommend using
React.PureComponentinstead.
But otherwise this looks okay 👍
Unfortunately it looks like an earlier PR has caused a merge conflict. Would you rebase this so I can merge it?
bvaughn
reviewed
Oct 10, 2017
content/docs/addons.md
Outdated
| <<<<<<< HEAD | ||
| - [`PureRenderMixin`](pure-render-mixin.html). Use [`React.PureComponent`](/docs/react-api.html#reactpurecomponent) instead. | ||
| - [`shallowCompare`](shallow-compare.html), a helper function that performs a shallow comparison for props and state in a component to decide if a component should update. We recommend using [`React.PureComponent`](/docs/react-api.html#reactpurecomponent) instead. | ||
| ======= | ||
| - [`PureRenderMixin`](pure-render-mixin.html). Use [`React.PureComponent`](/docs/react-api.html#reactpurecomponent) instead. |
There was a problem hiding this comment.
Looks like this didn't get merged correct
There was a problem hiding this comment.
Sorry, I'm so silly.
|
Thanks 😄 |
jhonmike
pushed a commit
to jhonmike/reactjs.org
that referenced
this pull request
Jul 1, 2020
@boniattirodrigo LGTM 👍 PR aprovada! Obrigado pela contribuição!
BetterZxx
pushed a commit
to BetterZxx/react.dev
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #84
Recommended
PureComponentinstead ofshallowCompareon Addons page.