Skip to content

Add canonical url to the head section #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sophiebits merged 7 commits into from
May 16, 2019
Merged

Add canonical url to the head section #1987

sophiebits merged 7 commits into from
May 16, 2019

Conversation

@george-veras
Copy link
Contributor

@george-veras george-veras commented May 11, 2019 •
edited by sophiebits
Loading

Fixes #1964.

@reactjs-bot
Copy link

reactjs-bot commented May 11, 2019 •
edited
Loading

Deploy preview for reactjs ready!

Built with commit 6a47d60

https://deploy-preview-1987--reactjs.netlify.com

@george-veras
Copy link
Contributor Author

george-veras commented May 13, 2019

Hi @gaearon and @sophiebits ! I'm willing to invest time on this wonderful community but I need some help to get involved, so if I got something wrong on this PR please provide me some feedback and I will be more than happy to work on it and learn more from the project.

@sophiebits
Copy link
Member

sophiebits commented May 13, 2019

Can you please:

  • Rename the property ogUrl to canonicalUrl
  • Check each page that uses the TitleAndMetaTags component and have it pass in a URL if possible
  • Change the canonical URL for the homepage from https://reactjs.org/index.html to just https://reactjs.org/

@george-veras
Copy link
Contributor Author

george-veras commented May 14, 2019

Count on me @sophiebits, thanks for that by the way :)

sophiebits
sophiebits reviewed May 15, 2019
View reviewed changes
src/pages/languages.js Outdated
<Header>Languages</Header>
<TitleAndMetaTags title="React - Languages" />
<TitleAndMetaTags
canonicalUrl={`${urlRoot}/languages`}
Copy link
Member

@sophiebits sophiebits May 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the trailing slashes to this and /versions/? To match the URL you get redirected to if you visit /languages.

Otherwise I think this looks good.

Copy link
Contributor Author

@george-veras george-veras May 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! No problem at all, I see your point ;)

@george-veras
Copy link
Contributor Author

george-veras commented May 15, 2019

Done! This issue was perfect for me to get to know better this project.
I really appreciate your help and feedback @sophiebits, thanks for your time :)
Please let me know if there is anything else I can do, can't wait to continue working on this project!

@sophiebits
Copy link
Member

sophiebits commented May 16, 2019

This looks great. Thank you so much!

@sophiebits sophiebits merged commit dd79941 into reactjs:master May 16, 2019
@kambleaa007
Copy link

kambleaa007 commented May 16, 2019 •
edited
Loading

Hi @gaearon and @sophiebits ! I'm willing to invest time on this wonderful community but I need some help to get involved, so if I got something wrong on this PR please provide me some feedback and I will be more than happy to work on it and learn more from the project.

I wanted too, :)
But, i didnt know how to deal with it....

BetterZxx pushed a commit to BetterZxx/react.dev that referenced this pull request Mar 21, 2023
@reactjs-translation-bot @QC-L
docs(en): merge reactjs.org into zh-hans (reactjs#228)
923843e 
* Add canonical url to the head section (reactjs#1987)

* Update conferences.md (reactjs#2002)

This PR updates the page to be more current.

* Update hooks-effect.md (reactjs#2005)

* docs(cn): fix conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sophiebits sophiebits sophiebits left review comments

@lex111 lex111 lex111 approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add <link rel="canonical"> tag to all pages

6 participants

@george-veras @reactjs-bot @sophiebits @kambleaa007 @lex111 @facebook-github-bot