Skip to content

added stackblitz to playground #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devpato
Copy link
Contributor

@devpato devpato commented Feb 19, 2020

Stackblitz supports ReactJS as a playground.

https://stackblitz.com/fork/react

@facebook-github-bot
Copy link
Collaborator

Hi @devpato!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@reactjs-bot
Copy link

reactjs-bot commented Feb 19, 2020

Deploy preview for reactjs ready!

Built with commit 8772e8a

https://deploy-preview-2759--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@EricSimons
Copy link
Contributor

@devpato yay! Awesome work 👏 Perhaps you could change the link to point at https://stackblitz.com/fork/react? That should ensure anyone clicking that link lands on a fresh React project. Other than that LGTM!

I changed the link based on comment from @EricSimons
@devpato
Copy link
Contributor Author

devpato commented Feb 20, 2020

@devpato yay! Awesome work 👏 Perhaps you could change the link to point at https://stackblitz.com/fork/react? That should ensure anyone clicking that link lands on a fresh React project. Other than that LGTM!

done :)

@devpato
Copy link
Contributor Author

devpato commented Mar 2, 2020

Hi! I'm curios. when is this going to be merged? Or do I need to do something else on my side. Thanks :)

@threepointone threepointone merged commit 869c740 into reactjs:master Mar 9, 2020
threepointone pushed a commit that referenced this pull request Mar 9, 2020
threepointone pushed a commit that referenced this pull request Mar 9, 2020
@threepointone
Copy link
Contributor

merged this by mistake, sorry. I think we're comfortable with our current recommendations.

@EricSimons
Copy link
Contributor

@threepointone considering I created the initial PR that enabled y'all to continue using codepen (#245), might the team be open to reconsidering this decision to ensure there's no signaling of favoritism in the community?

@threepointone
Copy link
Contributor

Yeah I thought about this more and have reconsidered, and I apologise for removing it. Let me revert my revert :)

threepointone pushed a commit that referenced this pull request Mar 9, 2020
threepointone pushed a commit that referenced this pull request Mar 9, 2020
@threepointone
Copy link
Contributor

#2821 sorry again!

@EricSimons
Copy link
Contributor

No worries at all! Thank you for all the hard work you & the team do to make React great ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants