fix: extract instantiation of Remarkable#2813
Merged
threepointone merged 1 commit intoMar 9, 2020
Merged
Conversation
|
Deploy preview for reactjs ready! Built with commit 62d5d25 |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋!
Originally in the example A Component Using External Plugins
Remarkablewas instantiated each time render was called, while I believe the whole point of this example is to show how React can be integrated with other libraries, taking into account different lifecycles and how they're tied together.With this change the plugin will be instantiated in the constructor, because it makes sense for it to exist throughout the full lifecycle of the component and the example will showcase the more complete and usual use-case this way.