Skip to content

Updates CrowdIn configuration to use /docs/lang/folder/file.md #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2017

Conversation

ericnakagawa
Copy link
Contributor

This PR changes where localized files, downloaded from CrowdIn, are output.

To verify you can run crowdin upload and download locally from reacjs.org folder:

crowdin --config crowdin.yaml upload sources --auto-update -b test-17
crowdin --config crowdin.yaml download -b test-17

The files will then be available in reactjs.org/docs/*.

@reactjs-bot
Copy link

Deploy preview ready!

Built with commit 1fe0a1b

https://deploy-preview-301--reactjs.netlify.com

@bvaughn bvaughn merged commit f8ec389 into reactjs:master Nov 18, 2017
@bvaughn
Copy link
Contributor

bvaughn commented Nov 18, 2017

Thanks Eric.

@bvaughn
Copy link
Contributor

bvaughn commented Nov 18, 2017

cc @clemmy We'll want to merge this into our crowdin integration branch.

@clemmy clemmy mentioned this pull request Nov 20, 2017
@clemmy
Copy link
Contributor

clemmy commented Nov 20, 2017

Yup, we can probably just merge master in. I'll submit a PR.

@clemmy
Copy link
Contributor

clemmy commented Nov 20, 2017

@ericnakagawa I built and downloaded the translation zip, and I see 3 folders after extracting: master, test-16, and test-17. Looking at the contents of each one: master looks recursive, which isn't what we want, and the contents of test-17 seem to be more aligned with what I was expecting, but it only has blog and docs folder underneath a locale directory. (Also the contents are in English). Is this what is expected, or am I doing something wrong?

@clemmy
Copy link
Contributor

clemmy commented Nov 20, 2017

screen shot 2017-11-19 at 8 54 46 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants