Skip to content

FIX: Various (~10) hrefs - beta.reactjs.org -> react.dev 🔗 #5768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

Pranav-yadav
Copy link
Contributor

@Pranav-yadav Pranav-yadav commented Mar 19, 2023

Summary

This diff fixes various hrefs - beta.reactjs.org -> react.dev 🔗 across react.dev codebase :)

How did you test this change?

I opened the old links in the browser; which redirect to the new pages and replaced the with the same :)

NOTE: I have skipped the hrefs from blogs, for example "/intro-to-hooks.html" is not auto redirected, though their is no explicit learn page for hooks; this API ref. https://react.dev/reference/react looks right candidate for auto redirect at least for now.

Finally ran:

  • yarn check-all --> #00ff00

@github-actions
Copy link

github-actions bot commented Mar 19, 2023

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 75.67 KB (🟡 +1 B) 168.63 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@Pranav-yadav
Copy link
Contributor Author

NOTE: I have skipped the hrefs from blogs, for example "/intro-to-hooks.html" is not auto redirected, though their is no explicit learn page for hooks; this API ref. https://react.dev/reference/react looks right candidate for auto redirect at least for now.

@gaearon WDYT?

@Pranav-yadav Pranav-yadav changed the title FIX: Various hrefs - beta.reactjs.org -> react.dev 🔗 FIX: Various (~10) hrefs - beta.reactjs.org -> react.dev 🔗 Mar 19, 2023
@Pranav-yadav Pranav-yadav changed the title FIX: Various (~10) hrefs - beta.reactjs.org -> react.dev 🔗 FIX: Various (~10) hrefs - beta.reactjs.org -> react.dev 🔗 Mar 19, 2023
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I outlined a few changes — let's change those, and then change the rest with the same approach

@Pranav-yadav
Copy link
Contributor Author

ping @gaearon :)
Lmk if anything is missed...

@gaearon gaearon merged commit 963829f into reactjs:main Mar 21, 2023
@Pranav-yadav Pranav-yadav deleted the fix/hrefs branch March 21, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants