Skip to content

Fix stylesheet precedence example #7235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

EricCote
Copy link
Contributor

The precedence prop documentation for <style> and <link> was fixed last May in this pull request:
#6908
(Precedence is now using any name, instead of "high", "medium" or "low")

But the code example accompanying the <link> documentation was not fixed.

There was even a comment in the doc about the fact that precedence didn't seem to work. -- It did work, it's just that it's more of a grouping behavior than an ordering behavior. So you need at least 3 <link> to visibly show that grouping behavior.

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 3:58pm
react-dev ✅ Ready (Inspect) Visit Preview Dec 16, 2024 3:58pm

Copy link

github-actions bot commented Oct 20, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg thank you, this was so confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants