Skip to content

Update your-first-component.md: Show example rendered output as <img> instead of <img /> #7757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chipit24
Copy link

@chipit24 chipit24 commented Apr 21, 2025

In HTML, img elements are void elements that don't have an end tag and are not self-closing. This is what you would see if you opened the DOM in any modern browser; this PR updates the Using a component → What the browser sees section of the docs to more accurately reflect this.

Also, in other parts of the docs, e.g. at Writing Markup with JSX → Converting HTML to JSX, the img tag is correctly written:

<img 
  src="https://i.imgur.com/yXOvdOSs.jpg" 
  alt="Hedy Lamarr" 
  class="photo"
>

And an explanation is even given later on, though it's inaccurate since HTML technically does not have close-closing tags (I'll get another PR up to update that we well):

JSX requires tags to be explicitly closed: self-closing tags like <img> must become <img /> [...]


Aside (interesting read 😁): The case against self-closing tags in HTML by Jake Archibald (06 July 2023)

In HTML, `img` elements are void elements that don't have an end tag and are not self-closing. This is what you would see if you opened the DOM in any modern browser, so I think the docs should accurately reflect this.
@facebook-github-bot
Copy link
Collaborator

Hi @chipit24!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants