Skip to content

Sync with reactjs.org @ e3cf542e #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 9, 2019
Merged

Sync with reactjs.org @ e3cf542e #4

merged 4 commits into from
Feb 9, 2019

Conversation

reactjs-translation-bot
Copy link
Contributor

This PR was automatically generated.

Merge changes from reactjs.org at e3cf542

No conflicts were found.

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from master and cause them to show
up as conflicts the next time we merge.

DenrizSusam and others added 3 commits February 8, 2019 13:24
@tesseralis tesseralis requested review from nampdn and ltmylinh February 9, 2019 01:59
@tesseralis
Copy link
Member

@nampdn @ltmylinh could you take a look at this? This is to bring the branch up to date with the original repo. It seems like the checks are failing because of an audio file:

Mixed content detected

Although you have enabled HTTPS on your site, we’ve detected some content that’s still being served over an HTTP connection.

In blog/2015/03/30/community-roundup-26.html:

audio http://fdlyr.co/d/changelog/cdn.5by5.tv/audio/broadcasts/changelog/2015/changelog-149.mp3

@ltmylinh
Copy link
Collaborator

ltmylinh commented Feb 9, 2019

Hi @tesseralis I just took a look on this issue. We can fix this by changing the http://fdlyr.co/d/changelog/cdn.5by5.tv/audio/broadcasts/changelog/2015/changelog-149.mp3 into https://fdlyr.co/d/changelog/cdn.5by5.tv/audio/broadcasts/changelog/2015/changelog-149.mp3.

Copy link
Collaborator

@nampdn nampdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI can pass with http link due to Netlify scanner, but the https link is inaccessible.

Hopefully the origin repo will fix this link too, because in production with site loaded via https could not load content via http: https://reactjs.org/blog/2015/03/30/community-roundup-26.html

@tesseralis
Copy link
Member

@nampdn yeah, hopefully, though it's an old blog post so they might not care to update it.

@tesseralis tesseralis merged commit 0fee9b3 into master Feb 9, 2019
@nampdn nampdn deleted the sync-e3cf542e branch February 9, 2019 04:10
Ryan-LT pushed a commit that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants