enable Netty leak detector extension#3064
Closed
sullis wants to merge 1 commit into
Closed
Conversation
sullis
force-pushed
the
NettyLeakDetectorExtension
branch
2 times, most recently
from
4a3f1b3 to
abc1bb1
Compare
sullis
force-pushed
the
NettyLeakDetectorExtension
branch
3 times, most recently
from
1649d9c to
fea9ce8
Compare
Contributor
Author
|
I observed a failure in GitHub Actions ubuntu-20.04 
|
sullis
force-pushed
the
NettyLeakDetectorExtension
branch
3 times, most recently
from
7c864c5 to
ea72399
Compare
sullis
force-pushed
the
NettyLeakDetectorExtension
branch
2 times, most recently
from
a5abd65 to
cb3b889
Compare
Contributor
Author
|
GitHub Actions CI: |
sullis
force-pushed
the
NettyLeakDetectorExtension
branch
3 times, most recently
from
a0a3017 to
9fc0757
Compare
sullis
force-pushed
the
NettyLeakDetectorExtension
branch
from
9fc0757 to
306ba93
Compare
sullis
force-pushed
the
NettyLeakDetectorExtension
branch
from
100ad03 to
87d0929
Compare
violetagg
requested changes
Feb 17, 2025
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved. | |||
| * Copyright (c) 2020-2024 VMware, Inc. or its affiliates, All Rights Reserved. | |||
Member
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2020-2024 VMware, Inc. or its affiliates, All Rights Reserved. | |
| * Copyright (c) 2020-2025 VMware, Inc. or its affiliates, All Rights Reserved. |
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2017-2023 VMware, Inc. or its affiliates, All Rights Reserved. | |||
| * Copyright (c) 2017-2024 VMware, Inc. or its affiliates, All Rights Reserved. | |||
Member
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2017-2024 VMware, Inc. or its affiliates, All Rights Reserved. | |
| * Copyright (c) 2017-2025 VMware, Inc. or its affiliates, All Rights Reserved. |
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2017-2022 VMware, Inc. or its affiliates, All Rights Reserved. | |||
| * Copyright (c) 2017-2024 VMware, Inc. or its affiliates, All Rights Reserved. | |||
Member
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2017-2024 VMware, Inc. or its affiliates, All Rights Reserved. | |
| * Copyright (c) 2017-2025 VMware, Inc. or its affiliates, All Rights Reserved. |
sullis
force-pushed
the
NettyLeakDetectorExtension
branch
from
87d0929 to
52fd009
Compare
Member
|
@sullis The build for this PR is not able to pass because it misses my suggestions. |
Member
|
There has been no updates since my last comment, let's close |
violetagg
added
status/declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept :)
OSS library: https://github.com/nettyplus/netty-leak-detector-junit-extension