Fix race condition in pending acquire timer management #4073
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a synchronisation issue between pendingOffer and drainLoop where a timer could be set after stopPendingCountdown was called, resulting in a timer that would never be stopped and would incorrectly fire even though the borrower had already been served. Signed-off-by: Violeta Georgieva <[email protected]>
violetagg
added a commit
that referenced
this pull request
Jan 23, 2026
There was a synchronisation issue between pendingOffer and drainLoop where a timer could be set after stopPendingCountdown was called, resulting in a timer that would never be stopped and would incorrectly fire even though the borrower had already been served. Signed-off-by: Violeta Georgieva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a synchronisation issue between
pendingOfferanddrainLoopwhere a timer could be set afterstopPendingCountdownwas called, resulting in a timer that would never be stopped and would incorrectly fire even though the borrower had already been served.