Skip to content

[4.x] Set up PHPStan on GitHub Actions #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[4.x] Set up PHPStan on GitHub Actions #64

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d0dc15d
ci: setup PHPStan
nhedger Sep 17, 2022
9d4a7f9
fix: install composer dependencies
nhedger Sep 17, 2022
e6dee26
ci: add PHP version to PHPStan job name
nhedger Sep 19, 2022
9945188
ci: use latest ubuntu version for PHPStan job
nhedger Sep 19, 2022
d29f87e
ci: use conventional array syntax
nhedger Sep 19, 2022
fc607da
ci: pin `phpstan` version
nhedger Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,23 @@ jobs:
coverage: xdebug
- run: composer install
- run: vendor/bin/phpunit --coverage-text

PHPStan:
name: PHPStan
runs-on: ubuntu-20.04
strategy:
matrix:
php: [ 8.1 ]
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Set up PHP
uses: shivammathur/setup-php@v2
Comment on lines +33 to +36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Remove names for consistency with other actions?

Suggested change
- name: Checkout
uses: actions/checkout@v3
- name: Set up PHP
uses: shivammathur/setup-php@v2
- uses: actions/checkout@v3
- uses: shivammathur/setup-php@v2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I'd rather we add names to the other steps for consistency x)

with:
php-version: ${{ matrix.php }}
coverage: none
tools: phpstan
- name: Install Composer dependencies
run: composer install
- name: Run static analysis
run: phpstan analyse
Comment on lines +41 to +44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Remove names for consistency with other actions?

Suggested change
- name: Install Composer dependencies
run: composer install
- name: Run static analysis
run: phpstan analyse
- run: composer install
- run: phpstan analyse

Loading