Factory method for streaming server test #469
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares to keep the change set in reactphp#425 for this file limited to the factory method.
|
@WyriHaximus I would ask the meta question here: What is gained by doing it this way? I don't want to talk bad about your changes, I'm just interested in where this is coming from :) |
|
@SimonFrings Main reason behind these test suite improvements is to make the diff for #425 smaller. But in its current shape this PR, with the current presentation makes less sense than it should. Will close this PR and file a successor tomorrow, which includes more improvements than the one presented here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares to keep the change set in #425 for this file limited to the factory method.