Provide all with interfaces (Protocol, ABC)

[Molandrious]

I have a simple example:

class InterfaceSomeRepo1(ABC): ...
class InterfaceSomeRepo2(ABC): ...

class SomeRepo1(InterfaceSomeRepo1): ...
class SomeRepo2(InterfaceSomeRepo2): ...

class SomeService1:
   repo1: InterfaceSomeRepo1
   repo2: InterfaceSomeRepo2


class MyProvider(Provider):
    repos = provide_all(
          SomeRepo1,
          SomeRepo2,
)

   services = provide_all(
          SomeService1,
    )

I get error Try use WithParents or changing provides. Is any way to resolve conflict without manual mapping interface class with implementation?

[Tishka17]

Did you try wrapping a class using WithParents?

[Molandrious]

I've tried like this:

repos = provide_all(
            WithParents[SomeRepo1],
            WithParents[SomeRepo2],

This didn't work, so for now I did it following way, but it would be great if the method with WithParents worked.

repos = provide_all(
             alias(SomeRepo1, provides=InterfaceSomeRepo1),
             alias(SomeRepo2, provides=InterfaceSomeRepo2),

Also some param with_parents for provide_all method would be great that wraps all providers inside.

[Tishka17]

Can you please provide minimal reproducible example showing en error and using WithParents?

[Molandrious]

Actually, it WithParents worked well with simple example, but it breaks if i add generic to base class (IRepository in this case):

import asyncio
from abc import ABC, abstractmethod
from dataclasses import dataclass

from dishka import Provider, Scope, WithParents, make_async_container, provide, provide_all


class Session:
    def get(self, v):
        return v


@dataclass
class SomeEntity:
    id: int


class IRepository[T](ABC):
    @abstractmethod
    async def get(self) -> T: ...


class ISomeEntityRepo(IRepository[SomeEntity], ABC):
    @abstractmethod
    async def get_specific(self): ...


class SQLAlchemyBaseRepo:
    session: Session

    def __init__(self, session: Session) -> None:
        self.session = session

    async def get(self):
        return 1


class SomeEntitySQLAlchemyRepo(SQLAlchemyBaseRepo, ISomeEntityRepo):
    async def get_specific(self):
        return 2


class Service:
    repo: ISomeEntityRepo

    # repo: IReleaseRepository
    def __init__(self, repo: ISomeEntityRepo):
        self.repo = repo

    async def get(self):
        return await self.repo.get()


class DBProvider(Provider):
    @provide(scope=Scope.REQUEST)
    async def session(self) -> Session:
        return Session()


class RepoProvider(Provider):
    scope = Scope.REQUEST

    repos = provide_all(
        WithParents[SomeEntitySQLAlchemyRepo],
    )


class ServiceProvider(Provider):
    scope = Scope.REQUEST

    services = provide_all(Service)


container = make_async_container(
    DBProvider(),
    RepoProvider(),
    ServiceProvider(),
)


async def main():
    async with container(scope=Scope.REQUEST) as _container:
        service = await _container.get(Service)
        print(await service.get())


if __name__ == '__main__':
    asyncio.run(main())

In this case i get error:

Traceback (most recent call last):
  File "F:\Coding\test\src\some.py", line 75, in <module>
    container = make_async_container(
        DBProvider(),
        RepoProvider(),
        ServiceProvider(),
    )
  File "F:\Coding\test\.venv\Lib\site-packages\dishka\async_container.py", line 275, in make_async_container
    ).build()
      ~~~~~^^
  File "F:\Coding\test\.venv\Lib\site-packages\dishka\registry_builder.py", line 462, in build
    GraphValidator(registries).validate()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "F:\Coding\test\.venv\Lib\site-packages\dishka\registry_builder.py", line 105, in validate
    raise GraphMissingFactoryError(
    ...<6 lines>...
    ) from None
dishka.exceptions.GraphMissingFactoryError: Cannot find factory for (ISomeEntityRepo, component=''). It is missing or has invalid scope.
   │   ◈ Scope.REQUEST, component='' ◈
   ▼   __main__.Service              
   ╰─> __main__.ISomeEntityRepo   ???
 Hint:
 * Try use `WithParents` or changing `provides` to `__main__.ISomeEntityRepo`. Found factories for more concrete dependencies: (__main__.SomeEntitySQLAlchemyRepo);

It's strange because Traceback has right implementation 'SomeEntitySQLAlchemyRepo', but still can't assing it to Service.

[chirizxc]

Linked: python/cpython#137120

[chirizxc]

We need use types.get_original_bases (Added in version 3.12)