Skip to content

Suggest user calling exec_type_checking in case of analysis errors#744

Open
ApusBerliozi wants to merge 23 commits into
reagento:developfrom
ApusBerliozi:651_user_calling_exec_type_checking
Open

Suggest user calling exec_type_checking in case of analysis errors#744
ApusBerliozi wants to merge 23 commits into
reagento:developfrom
ApusBerliozi:651_user_calling_exec_type_checking

Conversation

@ApusBerliozi

@ApusBerliozi ApusBerliozi commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Closes #651

Fetched code from _adaptix.type_tools.type_evaler.py and added it to dishka

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/dishka
  __init__.py
  src/dishka/text_rendering
  suggestion.py
Project Total  

This report was generated by python-coverage-comment-action

Comment thread src/dishka/code_tools/type_tools.py Outdated
from types import ModuleType


def _make_fragments_collector(*, typing_modules: Sequence[str]) \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Let's imagine that we have two files:

.. literalinclude:: /examples/dealing_with_type_checking/chat.py

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, put examples closer to the places they are used.

@ApusBerliozi ApusBerliozi Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to docs/advanced

@Tishka17

Copy link
Copy Markdown
Member

We should add hints into errors like adaptix does

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Suggest user calling exec_type_checking in case of analysis errors

2 participants