test: use structured Playwright locator for article title#1704
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
Automated security fix generated by Orbis Security AI
|
This has nothing to do with SQL injection btw Mr. Robot |
Author
|
You're right, this is not SQL injection. The scanner finding was a false positive because the template literal is used for a Playwright selector, not a SQL query. The actual code change only replaces a string-built selector:
with Playwright's structured locator API:
So the only reason to keep this PR would be as a minor e2e test maintainability/selector-robustness cleanup, not a security fix. I’m happy to retitle and rewrite the PR accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates an e2e test to use Playwright's structured
locator('h1', { hasText })API instead of embedding the title into a selector string.Notes
This is not a SQL injection fix. The earlier scanner finding was a false positive: the template literal is used in a Playwright selector, not a database query.
Why
Using
hasTextkeeps the text-matching argument separate from the selector string and makes the test intent clearer.Changes
specs/e2e/articles.spec.tsh1:has-text("${article.title}")withpage.locator('h1', { hasText: article.title })Verification
Automated security fix by OrbisAI Security