This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Fix date format for ASG creationDate #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@der-eismann @svenwltr Would it be possible to have a review on this PR? It basically prevent |
bjoernhaeuser
approved these changes
Aug 2, 2023
der-eismann
approved these changes
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#769 introduced a new Time format
2006-01-02 15:04:05.000 -0700 MSTwhich requires 3 digits for decimal seconds, making date like2023-05-17 10:01:12.14 +0000 UTCfailing to parse.Fixing the filter to parse any decimal second.
However the filter should never have been added as it's the property that should be correctly serialized to a string (and not relying on Go default
time.Timeto string print) the same way as it's done forEC2Instancefor instance.Leaving the fixed date format just in case it's used somewhere else.