Skip to content

[Symfony 7.3] Remove Argument argument: mode on InvokableCommandInputAttributeRector #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

[Symfony 7.3] Remove Argument argument: mode on InvokableCommandInputAttributeRector #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Symfony73/Rector/Class_/InvokableCommandInputAttributeRector/Fixture/some_command.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ use Symfony\Component\Console\Input\InputOption;
#[AsCommand(name: 'some_name')]
final class SomeCommand
{
public function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: 'argument', mode: InputArgument::REQUIRED, description: 'Argument description')]
public function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: 'argument', description: 'Argument description')]
string $argument, #[\Symfony\Component\Console\Attribute\Command\Option]
$option, OutputInterface $output): int
{
Expand Down
2 changes: 1 addition & 1 deletion ...s_/InvokableCommandInputAttributeRector/Fixture/some_command_with_method_chaining.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ use Symfony\Component\Console\Input\InputOption;
#[AsCommand(name: 'some_name')]
final class SomeCommandWithMethodChaining
{
public function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: 'argument', mode: InputArgument::REQUIRED, description: 'Argument description')]
public function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: 'argument', description: 'Argument description')]
string $argument, #[\Symfony\Component\Console\Attribute\Command\Option]
$option, OutputInterface $output): int
{
Expand Down
2 changes: 1 addition & 1 deletion ...or/Class_/InvokableCommandInputAttributeRector/Fixture/some_command_with_set_help.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ final class SomeCommandWithSetHelp
$this->setHelp('argument');
}

public function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: 'argument', mode: InputArgument::REQUIRED, description: 'Argument description')]
public function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: 'argument', description: 'Argument description')]
string $argument, #[\Symfony\Component\Console\Attribute\Command\Option]
$option, OutputInterface $output): int
{
Expand Down
2 changes: 1 addition & 1 deletion ...Rector/Class_/InvokableCommandInputAttributeRector/Fixture/with_optional_argument.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ use Symfony\Component\Console\Input\InputOption;
#[AsCommand(name: 'some_name')]
final class WithOptionalArgument
{
public function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: 'argument', mode: InputArgument::OPTIONAL, description: 'Argument description')]
public function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: 'argument', description: 'Argument description')]
?string $argument, #[\Symfony\Component\Console\Attribute\Command\Option]
$option, OutputInterface $output): int
{
Expand Down
2 changes: 1 addition & 1 deletion ...ymfony73/Rector/Class_/InvokableCommandInputAttributeRector/Fixture/with_override.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ use Symfony\Component\Console\Input\InputOption;
#[AsCommand(name: 'some_name')]
final class WithOverride
{
public function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: 'argument', mode: InputArgument::REQUIRED, description: 'Argument description')]
public function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: 'argument', description: 'Argument description')]
string $argument, #[\Symfony\Component\Console\Attribute\Command\Option]
$option, OutputInterface $output): int
{
Expand Down
1 change: 0 additions & 1 deletion rules/Symfony73/NodeFactory/CommandInvokeParamsFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ private function createArgumentParams(array $commandArguments): array
new FullyQualified(SymfonyAttribute::COMMAND_ARGUMENT),
[
new Arg(value: $commandArgument->getName(), name: new Identifier('name')),
new Arg(value: $commandArgument->getMode(), name: new Identifier('mode')),
new Arg(value: $commandArgument->getDescription(), name: new Identifier('description')),
]
),
Expand Down
2 changes: 1 addition & 1 deletion rules/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public function execute(InputInterface $input, OutputInterface $output)
final class SomeCommand
{
public function __invoke(
#[Argument(name: 'argument', mode: Argument::REQUIRED, description: 'Argument description')]
#[Argument(name: 'argument', description: 'Argument description')]
string $argument,
#[Option]
bool $option = false,
Expand Down
2 changes: 1 addition & 1 deletion tests/Set/Symfony73/Fixture/command_remove_config.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ The <info>%command.name%</info> command will do some
TXT)]
final class SomeCommand
{
public function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: 'argument', mode: InputArgument::REQUIRED, description: 'Argument description')]
public function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: 'argument', description: 'Argument description')]
string $argument, #[\Symfony\Component\Console\Attribute\Command\Option]
$option, OutputInterface $output): int
{
Expand Down
Loading