This repository was archived by the owner on Nov 8, 2018. It is now read-only.
Workable API Proxy #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use WORKABLE_KEY; Add .env docs;
Added workable api routes; Refactored workable;
|
Fetch does not reject when the response comes back with a 4xx or 5xx status. whatwg/fetch#18. This will need to be handled by us. |
Add docs for fetch proxy;
Update server build to use node5 babel preset;
| done(); | ||
| }; | ||
| mockWorkable.getJobs.returns(Promise.resolve('test')); | ||
| routes.getJobs(req, res); |
There was a problem hiding this comment.
Just a thought we could also use https://github.com/domenic/chai-as-promised/ - might make the tests more readable.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/api/get-jobssuccess/api/get-jobsfailures