Put color styles in settings so that they can be scoped to a chart#125
Merged
mhooper-scottlogic merged 2 commits intodevelopfrom Mar 27, 2019
Merged
Put color styles in settings so that they can be scoped to a chart#125mhooper-scottlogic merged 2 commits intodevelopfrom
mhooper-scottlogic merged 2 commits intodevelopfrom
Conversation
Allows us to put multiple charts on a single page, where theme settings apply to only some of them
This is the same as Highcharts currently uses. Avoids having to create svg and dom elements to get the styles. Requires that the default style variables are set in the perspective-viewer layer.
Ro4052
approved these changes
Mar 27, 2019
mhooper-scottlogic
approved these changes
Mar 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows us to put multiple charts on a single page, where theme settings apply to only some of them.
The split-screen examples have been updated to show gold/silver/bronze on the middle chart only
Use
ShadyCSScomponent to get style variables directlyThis is the same as Highcharts currently uses.
Avoids having to create svg and dom elements to get the styles.
Requires that the default style variables are set in the perspective-viewer layer.