Set back to reference "cjs" dependency, with yarn focus#74
Merged
andy-lee-eng merged 3 commits intodevelopfrom Mar 5, 2019
Merged
Set back to reference "cjs" dependency, with yarn focus#74andy-lee-eng merged 3 commits intodevelopfrom
andy-lee-eng merged 3 commits intodevelopfrom
Conversation
This change requires the use of `yarn install --focus" in the perspective-viewer-d3fc folder, if you're only compiling the plugin (so that the dependency with the /cjs folder is pulled in locally)
Collaborator
Author
|
I have also updated the |
Ro4052
approved these changes
Mar 5, 2019
Must pick webpack 3.5.6 when doing `yarn install --focus`
Collaborator
Author
|
Update: I've added webpack as a devDependency, and now it works without globally installing webpack. However, when you run |
Ro4052
approved these changes
Mar 5, 2019
Ro4052
approved these changes
Mar 5, 2019
andy-lee-eng
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Set back to reference "cjs" dependency, with yarn focus This change requires the use of `yarn install --focus" in the perspective-viewer-d3fc folder, if you're only compiling the plugin (so that the dependency with the /cjs folder is pulled in locally) * Update to work without global install webpack Must pick webpack 3.5.6 when doing `yarn install --focus` * Silence webpack error relating to "@d3fc/d3fc-data-join" reference
redbearsam
pushed a commit
that referenced
this pull request
Mar 8, 2019
* Set back to reference "cjs" dependency, with yarn focus This change requires the use of `yarn install --focus" in the perspective-viewer-d3fc folder, if you're only compiling the plugin (so that the dependency with the /cjs folder is pulled in locally) * Update to work without global install webpack Must pick webpack 3.5.6 when doing `yarn install --focus` * Silence webpack error relating to "@d3fc/d3fc-data-join" reference
mhooper-scottlogic
pushed a commit
that referenced
this pull request
Mar 18, 2019
* Set back to reference "cjs" dependency, with yarn focus This change requires the use of `yarn install --focus" in the perspective-viewer-d3fc folder, if you're only compiling the plugin (so that the dependency with the /cjs folder is pulled in locally) * Update to work without global install webpack Must pick webpack 3.5.6 when doing `yarn install --focus` * Silence webpack error relating to "@d3fc/d3fc-data-join" reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change requires the use of `yarn install --focus" in the perspective-viewer-d3fc folder, if you're only compiling the plugin (so that the dependency with the /cjs folder is pulled in locally).
Other notes:
After
yarn install --focus, runningyarn watchin the perspective-viewer-d3fc folder failed, because it couldn't find webpack. I had to install webpack globally to get that to work again:I also found that the pre-commit hook failed (couldn't find
npm-run-alloreslintor any of their depdendencies). Rather than globally install all that lot, I just commented out the precommit hook in my /.git/hooks folder. Committing is now much quicker, and we lint-fix-on-save anyway.